resend2:PATCH: save a few bytes in arping

walter harms WHarms at bfs.de
Fri Apr 25 09:04:25 UTC 2008


this should fix the problems.
unfortunaly the saving is less now, but the readability is still better.

re,
 wh


Denys Vlasenko wrote:
> On Friday 25 April 2008 09:11, walter harms wrote:
>> +static void *cp_step(void *_dst,void *_src, size_t n)
>> +{
>> +  memcpy(_dst, _src, n);
> 
> Indentation is inconsistent with the rest of the file.
> 
>> +
>> +  return _dst += n;
> 
> Incrementing the pointer of type void* is a gcc'ism.
> 
>>         ah->ar_op = option_mask32 & ADVERT ? htons(ARPOP_REPLY) : htons(ARPOP_REQUEST);
>> +       p=cp_step(p, &ME->sll_addr, ah->ar_hln);
> 
> Style is not consistent. See how = looks like in preceding line.
> 
> -               opt_complementary = "=1:Df:AU:c+";
> +               //              opt_complementary = "=1:Df:AU:c+";
> 
> Why did you kill -c option?
> --
> vda
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arping.diff
Type: text/x-patch
Size: 639 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20080425/594afaef/attachment-0002.bin 


More information about the busybox mailing list