I just run the tests in the testsuite...

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Wed Apr 23 12:41:10 UTC 2008


On Wed, 23 Apr 2008, Denys Vlasenko wrote:

> There is a bigger problem:
>
> test x"`date -u`" = x"`busybox date -u`"
>
> will succeed, always, for someone who has busybox applets installed
> as primary tools on development machine (I do that).

True.

> > Please also take a look at the proposed patch.  It mainly helps to
> > avoid backup files and .svn directories.  It also more
> > consistently quotes file names (guard in case someone gets the
> > wonderful idea to create files with embedded special characters).
>
> Applied, thanks

But testsuite/date/date-u-works r21806 will _always_ fail now :(

I proposed this:

Index: date/date-u-works
===================================================================
--- date/date-u-works   (revision 21643)
+++ date/date-u-works   (working copy)
@@ -1,2 +1,2 @@
-test x"`date -u`" = x"`busybox date -u`"
-
+d=11:22:33
+test x"`date -u -d $d`" = x"`busybox date -u -d $d`"

you checked in this:

Index: testsuite/date/date-u-works
===================================================================
--- testsuite/date/date-u-works (revision 21806)
+++ testsuite/date/date-u-works (working copy)
@@ -1,2 +1,2 @@
-test x"Wed Apr 23 11:22:33 UTC 2008" = x"`busybox date -u -d 11:22:33`"
+test x"`date -u`" = x"`busybox date -u`"

Something went wrong.


Cheers,

-- 
Cristian



More information about the busybox mailing list