[PATCH] start-stop-daemon: make --exec follow symlinks.

Joakim Tjernlund Joakim.Tjernlund at transmode.se
Sun Apr 20 14:50:21 UTC 2008


> -----Original Message-----
> From: Denys Vlasenko [mailto:vda.linux at googlemail.com]
> Sent: den 20 april 2008 16:27
> To: Joakim Tjernlund
> Cc: busybox at busybox.net
> Subject: Re: [PATCH] start-stop-daemon: make --exec follow symlinks.
> 
> On Sunday 20 April 2008 10:57, Joakim Tjernlund wrote:
> > > Fixed it. Also decided to go your way and use open_read_close
> > > (not xmalloc one). It is very slightly bigger but doesn't do
> > > so many malloc/realloc/free's.
> >
> > But you do lots of xstat().
> > Moving only xstat() really is a bug waiting to happen as this
> > deviates from the rest of the option handling.
> 
> Fixed that.

Just the xstat()? Didn't you find the change to xmalloc_open_read_close()
useful?

> I must be particularly dense these days. :(

Not really, you do a very good job with bb. Not sure why our
exchange got so confusing.

  Jocke




More information about the busybox mailing list