[PATCH] start-stop-daemon: make --exec follow symlinks.

[Joakim Tjernlund]

> -----Original Message-----
> From: Denys Vlasenko [mailto:vda.linux at googlemail.com]
> Sent: den 19 april 2008 22:22
> To: Joakim Tjernlund
> Cc: busybox at busybox.net
> Subject: Re: [PATCH] start-stop-daemon: make --exec follow symlinks.
> 
> On Saturday 19 April 2008 21:56, Joakim Tjernlund wrote:
> > > > > "name" is unused now. Don't introduce new warnings.
> > > >
> > > > yes, small mistake. I can fix that and commit it if you don't mind?
> > >
> > > I applied the patch, see attached. Thanks!
> >
> > Don't attach, makes it to comment.
> > reviewed your patch and found:
> > 	if (execname)
> > 		xstat(execname, &execstat);
> >
> > xstat is an improvement compared to my patches I sent a few hours ago.
> > I can fix that, because I rather commit the series I sent that just this single one.
> >
> > I got a cleanup patch queued up after that which will remove the
> > second argument to pid_is_exec(), pid_is_user() and pid_is_cmd()
> 
> Oops... I was applying your changes (somewhat edited) to svn
> all this time. Sorry if this caused you trouble.

It did, and I am too lazy to redo them yet one more time. Another
problem is that I don't know if they are correct anymore since you edited
them. It had been much better if you applied them as is and then
applied your mods on top.

> 
> I think now all your fixes to start-stop-daemon are in svn.
> 
> Let me know if you see more problems, or have cleanups.

I do, you haven't applied the patch to pid_is_cmd(). That
part is still buggy(as I explained earlier), even in current svn.

 Jocke

PS.
   You didn't answer my question about committing directly to svn, to
   late for this round anyway.