Remove common patterns -- second try

Denys Vlasenko vda.linux at googlemail.com
Sun Sep 30 16:26:44 UTC 2007


On Sunday 30 September 2007 15:30, Loïc Grenié wrote:
>     I've tried to remove "common patterns" in the code.
>  Second try: I've changed bb_\(p?\)error_msg\(_and_die\)("%s", \(.*\))
>  in bb_simple_\1error_msg\2(\3).


-#ifdef VERSION_WITH_WRITEV
-.....
-#endif


Why did you remove it?

cc1: warnings being treated as errors
libbb/perror_msg.c: In function 'bb_simple_perror_msg':
libbb/perror_msg.c:24: warning: implicit declaration of function 'bb_simple_error_msg'
make[1]: *** [libbb/perror_msg.o] Error 1
make: *** [libbb] Error 2

You don't have bb_simple_error_msg() in your patch.

I was trying to compile busybox with attached .config.

Please resend.
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.bz2
Type: application/x-bzip2
Size: 4075 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20070930/e4bb3bf0/attachment-0002.bin 


More information about the busybox mailing list