[PATCH] Tar with transformer (gzip, bzip2, ...) on NOMMU

Alex Landau landau_alex at yahoo.com
Mon Sep 10 06:53:58 UTC 2007


--- Denys Vlasenko <vda.linux at googlemail.com> wrote:

> On Sunday 09 September 2007 06:33, Alex Landau wrote:
> > 
> > --- Alex Landau <landau_alex at yahoo.com> wrote:
> > 
> > > --- Denys Vlasenko <vda.linux at googlemail.com> wrote:
> > > 
> > > > On Wednesday 05 September 2007 12:12, Alex Landau wrote:
> > > > [snip]
> > > > Applied with very minor changes, many thanks!
> > > > 
> > > > (bloatcheck says 0 bytes difference for MMU)
> > > 
> > > Thanks.
> > > Small question: in open_transformer() you changed perror() and _exit() to
> > > bb_perror_and_die() which is not defined. Forgot to svn add? Also, you removed the
> > > comment saying that we should use _exit() and not exit(), so I guess
> bb_perror_and_die
> > > is
> > > not just a mistyped bb_perror_msg_and_die...
> > > 
> > > Alex
> > > 
> > 
> > Bumping....
> 
> Sorry, I should have tested NOMMU build...
> 
> I fixed it in svn now.

Compiles now, thanks.

> 
> It is in fact mistyped bb_perror_msg_and_die(). I think we can call it here,
> because we do not use atexit, and it flushes stdio internally, so exit
> inside bb_perror_msg_and_die() will actually work as intended.

I hope... Anyway that perror will only happen if exec has failed, which should
(hopefully) occur only during development, if at all.

> 
> Another thing: currentl all unpackers have the same
> command line. Attached patch uses this and reduces size by 70 bytes
> by giving up the ability to run arbitrary command line.
> What do you think?

No problems on my side. Plus, since the full version is committed, if another
incompatible unpacker is added, we can always return to that version (or adapt the
unpacker, of course).

> vda

Alex


       
____________________________________________________________________________________
Moody friends. Drama queens. Your life? Nope! - their life, your story. Play Sims Stories at Yahoo! Games.
http://sims.yahoo.com/  



More information about the busybox mailing list