[PATCH] Tar with transformer (gzip, bzip2, ...) on NOMMU

[Denys Vlasenko]

On Sunday 09 September 2007 06:33, Alex Landau wrote:
> 
> --- Alex Landau <landau_alex at yahoo.com> wrote:
> 
> > --- Denys Vlasenko <vda.linux at googlemail.com> wrote:
> > 
> > > On Wednesday 05 September 2007 12:12, Alex Landau wrote:
> > > [snip]
> > > Applied with very minor changes, many thanks!
> > > 
> > > (bloatcheck says 0 bytes difference for MMU)
> > 
> > Thanks.
> > Small question: in open_transformer() you changed perror() and _exit() to
> > bb_perror_and_die() which is not defined. Forgot to svn add? Also, you removed the
> > comment saying that we should use _exit() and not exit(), so I guess bb_perror_and_die
> > is
> > not just a mistyped bb_perror_msg_and_die...
> > 
> > Alex
> > 
> 
> Bumping....

Sorry, I should have tested NOMMU build...

I fixed it in svn now.

It is in fact mistyped bb_perror_msg_and_die(). I think we can call it here,
because we do not use atexit, and it flushes stdio internally, so exit
inside bb_perror_msg_and_die() will actually work as intended.

Another thing: currentl all unpackers have the same
command line. Attached patch uses this and reduces size by 70 bytes
by giving up the ability to run arbitrary command line.
What do you think?
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zz.diff
Type: text/x-diff
Size: 6148 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20070909/2a73f7e7/attachment-0002.bin