Coupla bugs ? syslogd -C, logger, losetup

Mike mike-busybox at tiedyenetworks.com
Mon Oct 1 19:54:24 UTC 2007


Howdy,

    syslogd option paramater -C is not recognised in 1.7.1.

    I poked around and the culprit appears to be an extra semicolon in
the options parameter declaration for it. This trivial patch seems to do
the trick for me (compiled + tested minimally).


diff -ur busybox-1.7.1.orig/sysklogd/syslogd.c
busybox-1.7.1/sysklogd/syslogd.c
--- busybox-1.7.1.orig/sysklogd/syslogd.c       2007-09-03
11:48:35.000000000 +0000
+++ busybox-1.7.1/sysklogd/syslogd.c    2007-09-29 16:53:12.000000000 +0000
@@ -159,7 +159,7 @@
        USE_FEATURE_ROTATE_LOGFILE("b:" ) \
        USE_FEATURE_REMOTE_LOG(    "R:" ) \
        USE_FEATURE_REMOTE_LOG(    "L"  ) \
-       USE_FEATURE_IPC_SYSLOG(    "C::")
+       USE_FEATURE_IPC_SYSLOG(    "C:")
#define OPTION_DECL *opt_m, *opt_l \
        USE_FEATURE_ROTATE_LOGFILE(,*opt_s) \
        USE_FEATURE_ROTATE_LOGFILE(,*opt_b) \


	Also, losetup seems to not be working correctly and I can't seem to get 
it to work with my compressed loop device /dev/cloop/[0-7]. It looks 
like a flub with parsing argv but I ran out of time looking at it.

	ALSO, I just noticed, logger seems to only take the first argument on 
the command like for squirting into syslog. eg:

logger this is a test

	will only put 'this' into syslog and omit the rest. Past behaviour was 
to stuff everything into syslog. I can work around it by enclosing stuff 
in quotes but the previous behavior, I think, is more desireable.



	Thanks.
--
Do not try to make the creditors stop calling, for that is impossibe.
Instead, only try to realise the truth: THERE IS NO PHONE!
<a href="http://speedtest.dslreports.com"><img border=0 
src="http://www.dslreports.com/im/18224717/86472.png"></a>





More information about the busybox mailing list