[PATCH] who.c minor size reduction

Denys Vlasenko vda.linux at googlemail.com
Tue Nov 13 17:22:34 UTC 2007


On Sunday 11 November 2007 05:29, Tito wrote:
> Hi,
> this size reduces size of who.c by removing a variable.
> The patch is tested and works for me.
>
> Bloat o meter says:
> scripts/bloat-o-meter busybox_old busybox_unstripped
> function                                             old     new   delta
> who_main                                             279     271      -8

Applied, thanks!

> BTW: a silly question, why we don't remove the check for USER_PROCESS  in
> this line:
>
>           if (ut->ut_user[0] && ut->ut_type == USER_PROCESS)
>
>          so that we get the output of who -a for free and reduce
>          size at the same time. Currently there is no way
>          to do this. Output would be:
>
> ./busybox who
> USER       TTY      IDLE      TIME            HOST
> reboot     ~        ?         Nov 11 10:06:20
> runlevel   ~        ?         Nov 11 10:06:20
> LOGIN      tty1     03:17     Nov 11 10:06:47
> tito       tty2     00:01     Nov 11 13:22:31
> LOGIN      tty3     03:17     Nov 11 10:06:47
> LOGIN      tty4     03:17     Nov 11 10:06:47
> LOGIN      tty5     03:17     Nov 11 10:06:47
> LOGIN      tty6     03:17     Nov 11 10:06:47

Good idea, just do it conditionally, if -a is passed to who.
--
vda



More information about the busybox mailing list