Bug in bb 1.5.0 ifupdown applet

Nathan Angelacos nangel at nothome.org
Thu May 3 12:13:45 UTC 2007


Denis Vlasenko wrote:
> On Wednesday 02 May 2007 23:54, Natanael Copa wrote:
>> On Wed, 2 May 2007 23:22:35 +0200
>> Denis Vlasenko <vda.linux at googlemail.com> wrote:
>>
>>> Small question: after else below, we build new list,
>>> write it out if !NO_ACT, and then delete.
>>>
>>> If NO_ACT is true, then list is build and then deleted
>>> without any useful effect.
>>>
>>> Should we replace "else {...}" with "else if (!NO_ACT) {...}" ?
>> duh.. ofcourse... Yes I think we should.
>> Updated patch attatched.
> 
> Applied, thanks.
> --
> vda

Denis,

Sorry for the late reply...

I just tried the last patch and it works perfectly.   It would be 
helpful if this patch got added to fixes-1.5.0.

Many thanks to you and Natanael.





More information about the busybox mailing list