Bug in bb 1.5.0 ifupdown applet

Natanael Copa natanael.copa at gmail.com
Wed May 2 13:13:36 UTC 2007


On Wed, 2007-05-02 at 02:38 +0200, Denis Vlasenko wrote: 
> On Tuesday 01 May 2007 02:27, Nathan Angelacos wrote:
> > Hello,
> > 
> > The ifupdown applet in 1.5.0 appears to have a bug that was not present
> > in 1.4.1.  The bug is that /var/run/ifstate is not updated with all
> > interfaces if an interface stanza calls ifup statement to bring up a
> > second interface.
... 
> You can attempt to go after these solutions:
> 
> (a) provide a patch for ifupdown to read/write
>     /var/run/ifstate AFTER child if done.


Attatched.

The patch also removes this dead code (and memory leak):
-			/* iface_down */
-			const llist_t *list = state_list;
-			while (list) {
-				llist_add_to_end(&target_list, xstrdup(list->data));
-				list = list->link;
-			}
-			target_list = defn->autointerfaces;

(first copy state_list to target_list and next second just reassign
target_list???)

It would be nice if patch could go into 1.5.1.

Thanks!

Natanael Copa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reentrant-ifupdown.patch
Type: text/x-patch
Size: 3346 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20070502/a91c9b54/attachment-0002.bin 


More information about the busybox mailing list