trunk compilation broken
Bernhard Fischer
rep.dot.nop at gmail.com
Wed Mar 21 22:08:58 UTC 2007
On Wed, Mar 21, 2007 at 10:08:30PM +0100, Denis Vlasenko wrote:
>On Wednesday 21 March 2007 21:49, Denis Vlasenko wrote:
>> Hi Bernhard
>>
>> On Wednesday 21 March 2007 20:29, Bernhard Fischer wrote:
>> > the vi fiddling seems to have broken something (for me):
>> >
>> > $ svn info | grep Rev
>> > Revision: 18191
>> > Last Changed Rev: 18191
>> >
>> > editors/vi.c: In function 'colon':
>> > editors/vi.c:843: warning: comparison is always false due to limited
>> > range of data type
>>
>> It complains about c > 127:
>> c_is_no_print = c > 127 && !Isprint(c);
>>
>> c is of type char. How did it end up signed for you?
>>
>> CFLAGS += $(call cc-option,-funsigned-char -static-libgcc,)
>>
>> But before fixing that, please try whether attached patch
>> makes vi.c compile w/o warning with signed char.
>
>Actually, please try this updated one.
that silences vi.c, yay!
thanks and cheers,
now off to see why i managed to drop visible atexit along the way..
More information about the busybox
mailing list