[PATCH 1/8] busybox -- SELinux option support for coreutils: ver3

[Bernhard Fischer]

On Tue, Feb 27, 2007 at 08:42:58AM +0900, Yuichi Nakamura wrote:
>In previous patch, 
>definitions about another SELinux-related applet was included.
>I am sorry, and I've removed that one.
>Please use attached patch instead of busybox-coreutils-common-01.v4.patch.
>
>
>On Mon, 26 Feb 2007 10:31:14 +0900
>Yuichi Nakamura  wrote:
>
>> Thank you for review!
>> 
>> On Sat, 24 Feb 2007 16:01:14 +0100
>> Denis Vlasenko wrote:
>> > On Friday 23 February 2007 09:47, Yuichi Nakamura wrote:
>> > > [1/8] busybox-coreutils-common-01.v3.patch
>> > >  - common component for SELinux options, applets
>> > > 
>> > > Signed-off-by: Yuichi Nakamura <ynakam at hitachisoft.jp>
>> > > Signed-off-by: KaiGai Kohei <kaigai at kaigai.gr.jp>
>> > 
>> >         "       -i      Interactive, prompt before overwrite\n" \
>> >         "       -R,-r   Copy directories recursively\n" \
>> > -       "       -l,-s   Create (sym)links"
>> > +       "       -l,-s   Create (sym)links\n"
>> > 
>> >  #define cpio_trivial_usage \
>> > 
>> > Why?
>> Removed this one.
>> 
>> >  USE_RPM2CPIO(APPLET(rpm2cpio, _BB_DIR_USR_BIN, _BB_SUID_NEVER))
>> > +USE_RUNCON(APPLET(runcon, _BB_DIR_USR_BIN, _BB_SUID_NEVER))
>> >  USE_RUN_PARTS(APPLET_ODDNAME(run-parts, run_parts, _BB_DIR_BIN, _BB_SUID_NEVER, run_parts))
>> >  USE_RUNLEVEL(APPLET(runlevel, _BB_DIR_SBIN, _BB_SUID_NEVER))
>> > 
>> > *Must* be in ASCII order.
>> Fixed.

Also:

A couple of superfluous newlines for non SElinux were introduced in your
patch. E.g. just one:
@@ -1519,7 +1543,10 @@
        "       -m      Set permission modes\n" \
        "       -o      Set ownership\n" \
        "       -p      Preserve date\n" \
-       "       -s      Strip symbol tables"
+       "       -s      Strip symbol tables\n" \
+       USAGE_SELINUX( \
+       "       -Z      Set security context of copy" \
+       )

Please move the newline to the start of the SElinux string everywhere.


Index: selinux/Config.in
===================================================================
--- selinux/Config.in   (revision 17961)
+++ selinux/Config.in   (working copy)
...
+         Enable support for chcon command as a SELinux utility.

as an SELinux utility?
Also please add a terse description like:
+	Applet to change the security context

Same for runcon config entry