[PATCH] ping.c : fix min/max packet size usage

Denis Vlasenko vda.linux at googlemail.com
Thu Mar 1 22:23:26 UTC 2007


On Thursday 01 March 2007 10:23, Florian Fainelli wrote:
> Hi Denis,
> 
> Here is the rediff against the file you sent me, thanks for considering
> this patch.

Unfortunately, it introduces a regression:

unpatched:

# ./busybox ping -s 1000 127.0.0.1
PING 127.0.0.1 (127.0.0.1): 1000 data bytes
1008 bytes from 127.0.0.1: icmp_seq=0 ttl=64 time=0.0 ms
1008 bytes from 127.0.0.1: icmp_seq=1 ttl=64 time=0.0 ms
1008 bytes from 127.0.0.1: icmp_seq=2 ttl=64 time=0.0 ms
1008 bytes from 127.0.0.1: icmp_seq=3 ttl=64 time=0.0 ms

patched:

# ./busybox ping -s 1000 127.0.0.1
PING 127.0.0.1 (127.0.0.1): 1000 data bytes
^C
--- 127.0.0.1 ping statistics ---
4 packets transmitted, 0 packets received, 100% packet loss

--
vda



More information about the busybox mailing list