[PATCH Try#2 3/3] Major improvements to RPM

Steve M. stevem at inode.at
Tue Jun 12 20:52:19 UTC 2007


Hi folks,

I built a version from current svn with that patch (the #3) and it 
worked ok in a short test. During compilation I got these warnings:

archival/rpm.c:79: warning: initialization discards qualifiers from 
pointer target type
archival/rpm.c:268: warning: no previous prototype for 
‘rpm_construct_scan_state’
archival/rpm.c:272: warning: no previous prototype for 
‘rpm_destruct_scan_state’
archival/rpm.c: In function ‘DoInstallEraseUpdateSeqences’:
archival/rpm.c:679: warning: declaration of ‘sz’ shadows a previous local
archival/rpm.c:552: warning: shadowed declaration is here
archival/rpm.c: In function ‘DoQueryListFiles’:
archival/rpm.c:1080: warning: declaration of ‘pszRoot’ shadows a global 
declaration
archival/rpm.c:79: warning: shadowed declaration is here
archival/rpm.c: At top level:
archival/rpm.c:1179: warning: no previous prototype for ‘rpm_main’
archival/rpm.c: In function ‘rpm_main’:
archival/rpm.c:1192: warning: ISO C90 forbids mixed declarations and code
archival/rpm.c: In function ‘extract_cpio_gz’:
archival/rpm.c:1747: warning: passing argument 2 of 
‘rpm_open_transformer’ from incompatible pointer type
archival/rpm.c: At top level:
archival/rpm.c:300: warning: ‘exec_script’ declared ‘static’ but never 
defined
archival/rpm.c:1999: warning: ‘fileaction_list’ defined but not used
archival/rpm.c:520: warning: ‘PrintDependency’ defined but not used


I also have a general question about that.
At line 79 the following is declared:
static char *pszRoot, *szEmpty = "";

  szEmpty is only used once for
if(defaultPath)
   pszRoot = szEmpty;
else
   pszRoot = specifiedPath;

Is there a benefit from using szEmpty instead of simply doing pszRoot = 
""; ?

Greetings,
Steve M.



More information about the busybox mailing list