[patch]setfiles/restorecon applet

Tito farmatito at tiscali.it
Wed Jul 25 16:13:40 UTC 2007


On Tuesday 24 July 2007 02:08:24 Yuichi Nakamura wrote:
> Hi.
> 

snip

> 
> About sanitize_path, it is pending.
> Removing extra slashes is done only there in setfiles.c .
> Is removing extra slashes done in other applets?

Yes in devfsd, removing extra slashes at the end of filename:

in one earlier revision there was:

 /* strip last / from mount point, so we don't need to check for it later */
         while (argv[1][1] != '\0' && argv[1][strlen(argv[1]) - 1] == '/') 	 
                 argv[1][strlen(argv[1]) - 1] = '\0';

later it changed to

         mount_point = bb_simplify_path(argv[1]);

so far nobody complained.....
> If so, should it be in libbb?

Could be useful......
just my 0,02 €

Ciao,
Tito
> I've found bb_simplify_path, but it is expanding "." .
> 
> > >
> > > [snipping the rest of you patch for now]
> > > HTH,
> > --
> > vda
> 
> Attached is update.





More information about the busybox mailing list