[patch]setfiles/restorecon applet

Denis Vlasenko vda.linux at googlemail.com
Tue Jul 24 06:01:36 UTC 2007


On Tuesday 24 July 2007 01:08, Yuichi Nakamura wrote:
> Attached is update.

Applied to svn. Further reductions are possible:

        if (flags & OPT_e) {
                if (exclude_dir == NULL) {
                        bb_show_usage();
                }

I think it is already handled inside getopt32. IOW:
if() above is not needed at all, ok to remove?

                while (exclude_dir) {
                        if (add_exclude(llist_pop(&exclude_dir)))
                                exit(1);
                }

add_exclude is used only once here. Obviously you can make
it a void function which exits on errors.

        }

Can you test it?

Can you point me to FAQ/whetever how to install SELinux libs
so that I can at least compile this stuff myself? I suppose
this doesn't require SELinux-enabled kernel?
--
vda



More information about the busybox mailing list