Fwd: [PATCH] chpasswd applet size reduction and bugfix

Alexander Shishkin virtuoso at slind.org
Sat Jul 21 19:55:43 UTC 2007


On 7/21/07, Denis Vlasenko <vda.linux at googlemail.com> wrote:
> > it fixes also a bug in commandline parsing:
> > chpasswd must error out if -m and -e are set at the same time.
>
> Applied to svn (along with even more bugs fixed. It's scary how many
> of them were there).
>
> Alex, care to eyescan/test what in svn now?
Looks a whole lot better now (thanks a lot for your numerous fixes to this!).
Except:
- chpasswd.c:59 seems to have excessive indentation tab,
- may be it's time to move sizeof("$N$XXXXXXXX") to some header file,
since it's used in both passwd.c and chpasswd.c (I'm not quite sure
which header is better for such things if at all).

Regards,
-- 
Alex



More information about the busybox mailing list