[patch]setfiles/restorecon applet

[Denis Vlasenko]

On Friday 20 July 2007 05:29, Yuichi Nakamura wrote:
> Attached is updated patch.

I changed it a bit, see attached. Can you clarify this part?

        ret = lsetfilecon(my_file, newcon);
        if (ret) {
                bb_perror_msg("lsetfileconon(%s,%s)", my_file, newcon);
                goto out;
        }

 err:
        retval--;
 out:
        freecon(context);
        freecon(newcon);
        free(my_file_orig);
        return retval;
}

Looks like if lsetfilecon fails, we return success - ?!
Is it really right?
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.patch
Type: text/x-diff
Size: 22381 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20070720/0e7b743d/attachment-0002.bin