[PATCH] vi read-only mode bugfix and enhancement

Paul Fox pgf at brightstareng.com
Wed Jul 18 03:19:38 UTC 2007


 > > The attatched patch should not make things worse. If somebody find out
 > > that it introduces new bugs or have suggestions to improvements of the
 > > patch, let me know and I'll try to fix.
 > 
 > Wow. thanks!

i agree.  busybox vi has needed some work.

 > Applied to svn with minor changes. For example, we were comparing argv[0]
 > with "view", but argv[0] can be "/bin/view"! Right thing is 
 > 
 > 	strncmp(appliet_name, "view", 4)
 > 
 > BTW, any idea why strNcmp? Can it really be "viewsomething"? I'm no expert
 > on vi...

no.  it should be "vi", "ex", or "view".  (and busybox's vi will
almost certainly never be called "ex".  :-)

paul
=---------------------
 paul fox, pgf at brightstareng.com



More information about the busybox mailing list