[PATCH 1/7] bb_ioctl implementation

[Alex Landau]

Tito <farmatito at tiscali.it> wrote: Hi,
this series of 7 patches is a first attempt to add an ioctl api to libbb
and to use it in all applets where:

if ( ioctl() < 0 [!= 0])
 bb_perror_msg{and_die}();

or similar code is used.
[snip]

Critics, hints and help from the list is as always welcome.

Ciao,
Tito

Hi,
It looks really nice, only eye-tested though.
One small comment: ioctl(...) != 0 doesn't mean it's an error. the ioctl() may return a positive value, so I'd better have an ioctl(...) < 0 test. Especially when you return ret afterwards.
Regards,
Alex

 
---------------------------------
Don't get soaked.  Take a quick peak at the forecast 
 with theYahoo! Search weather shortcut.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.busybox.net/pipermail/busybox/attachments/20070711/0ce454be/attachment-0002.htm