[patch] coreutils/expr.c is this acceptable

[Denis Vlasenko]

On Sunday 01 July 2007 19:13, Cristian Ionescu-Idbohrn wrote:
> 
> Cheers,
> 

Do you mean that your gcc emits bogus warning for l too?
 
 static VALUE *eval6(void)
 {
-	VALUE *l, *r, *v = NULL /* silence gcc */, *i1, *i2;
+	VALUE *r, *i1, *i2;
+	VALUE *l = NULL, *v = NULL /* silence gcc */;
 	static const char * const keywords[] = {
 		"quote", "length", "match", "index", "substr", NULL
 	};
@@ -503,5 +504,3 @@
 
 	fflush_stdout_and_exit(null(v));
 }


This is better (no actual code generated:

	VALUE *l = l; /* silence gcc */
	VALUE *v = v; /* silence gcc */

--
vda