[PATCH 5/8] busybox -- libselinux utilities applets

KaiGai Kohei kaigai at kaigai.gr.jp
Mon Jan 29 14:44:19 UTC 2007


Hi, Thanks for your comments.

Russell Coker wrote:
> On Saturday 27 January 2007 07:10, "Christopher J. PeBenito" 
> <cpebenito at tresys.com> wrote:
>> On Thu, 2007-01-25 at 23:44 +0900, KaiGai Kohei wrote:
>>> [5/8] busybox-libselinux-05-avcstat.patch
>>>   avcstat reports SELinux AVC(Access Vector Cache) statistics.
>>>   AVC is a in-kernel data structure to accelerate SELinux's
>>>   decision making.
>> Are you sure this should be added?  It doesn't seem like it would be
>> used much.  I don't think most people are even aware that you can get
>> stats on the AVC, much less know what to do with them.
> 
> I agree.  avcstat is used only rarely and only in development.  I don't think 
> that it's something we need in production on an iPaQ, for system recovery, or 
> in an initramfs - therefore I think it's something that isn't needed in 
> busybox.
> 
> As for togglesebool, should such a thing even exist?  Before we had setenforce 
> we had avc_toggle which was very similar to togglesebool - and it was 
> generally regarded that avc_toggle should not exist.

Our primary motivation is that porting some of significant SELinux utilities
without any unexpected incompatibility.
Therefore, the serious of patches implements all of liblisenux utilities.

But your opinions are persuasive, I can agree to suspend the patches of
avcstat and togglesebool.

Denis, I would like to suspend the 5th and 6th patches by above reason.

> Good work on the busybox development KaiGai, it's something that needed to be 
> done for a while.  But I think you were a little over-enthusiastic in regard 
> to those two commands.

The list of our works (which include unsubmitted ones) are here:
   http://code.google.com/p/sebusybox/

We want any comments about its necessity and so on.

Thanks,
-- 
KaiGai Kohei <kaigai at kaigai.gr.jp>



More information about the busybox mailing list