svn commit: trunk/busybox/modutils

Peter Kjellerstedt peter.kjellerstedt at axis.com
Wed Jan 24 13:21:54 UTC 2007


The changes below (combined with the previous changes of
combining bool and prompt) does not match the previous 
(and I believe intended) behavior.  Previously, if 
NITPICK was not set, these variables would silently be 
set to y.  Now they will be undefined, which is not quite 
the same...

I think the configuration code was correct before, and
17492 and 17495 should be reverted.  (Unless of course
the idea behind these changes was to actually change
the default when NITPICK is not set, but then I believe
that should have been stated in the commit log.)

//Peter

> -----Original Message-----
> From: busybox-cvs-bounces at busybox.net 
> [mailto:busybox-cvs-bounces at busybox.net] On Behalf Of 
> vapier at busybox.net
> Sent: Wednesday, January 24, 2007 13:16
> To: busybox-cvs at busybox.net
> Subject: svn commit: trunk/busybox/modutils
> 
> 
> Author: vapier
> Date: 2007-01-24 04:16:08 -0800 (Wed, 24 Jan 2007)
> New Revision: 17495
> 
> Log:
> change "bool ... if OPT" to more common "depend ... OPT"
> 
> Modified:
>    trunk/busybox/modutils/Config.in
> 
> 
> Changeset:
> Modified: trunk/busybox/modutils/Config.in
> ===================================================================
> --- trunk/busybox/modutils/Config.in	2007-01-24 10:09:41 UTC 
> (rev 17494)
> +++ trunk/busybox/modutils/Config.in	2007-01-24 12:16:08 UTC 
> (rev 17495)
> @@ -91,9 +91,9 @@
>  	  module options from the configuration file. See option below.
>  
>  config FEATURE_MODPROBE_MULTIPLE_OPTIONS
> -	bool "Multiple options parsing" if NITPICK
> +	bool "Multiple options parsing"
>  	default y
> -	depends on MODPROBE
> +	depends on MODPROBE && NITPICK
>  	help
>  	  Allow modprobe to understand more than one option to pass to
>  	  modules.
> @@ -107,9 +107,9 @@
>  	  on storage capacity.
>  
>  config FEATURE_MODPROBE_FANCY_ALIAS
> -	bool "Fancy alias parsing" if NITPICK
> +	bool "Fancy alias parsing"
>  	default y
> -	depends on MODPROBE && FEATURE_2_6_MODULES
> +	depends on MODPROBE && FEATURE_2_6_MODULES && NITPICK
>  	help
>  	  Say 'y' here to enable parsing of aliases with underscore/dash
>  	  mismatch between module name and file name, along 
> with bus-specific
> 
> _______________________________________________
> busybox-cvs mailing list
> busybox-cvs at busybox.net
> http://busybox.net/cgi-bin/mailman/listinfo/busybox-cvs
> 



More information about the busybox mailing list