svn commit: trunk/busybox/shell

Eric Spakman E.Spakman at inter.nl.net
Tue Jan 9 22:00:45 UTC 2007


Hi Bernhard,

A small note.

> Didn't look in detail, but
> why isn't "[" USE_TEST too apart from lazyness WRT a big #if
> THIS|THAT|ONE_OF_THE_OTHERS around the safe_applets and related code ?
>
This part doesn't seem to be the cause of the "ash internal [" problem I
see, but an other part of the patch:
-	if (strchr(argv[0], '/') != NULL
-		|| is_safe_applet(argv[0])
+	if (strchr(argv[0], '/')

So I think, but not tested it yet, that the current revision will have
problems with all "ash internal" commands.

Eric




More information about the busybox mailing list