[PATCH 1/6] busybox -- SELinux option support for coreutils

Denis Vlasenko vda.linux at googlemail.com
Thu Feb 8 22:32:43 UTC 2007


On Thursday 08 February 2007 07:54, Yuichi Nakamura wrote:
> 
> [1/6] busybox-coreutils-common-01.patch
>  - usage.h for SELinux options
> 
> Signed-off-by: Yuichi Nakamura <ynakam at hitachisoft.jp>


@@ -1299,9 +1301,8 @@
 #define id_full_usage \
        "Print information for USERNAME or the current user" \
        "\n\nOptions:\n" \
-	USE_SELINUX( \
-       "	-c	Prints only the security context\n") \
-       "	-g	Prints only the group ID\n" \
+	   USAGE_SELINUX("	-Z	prints only the security context\n")	\
+	   "	-g	Prints only the group ID\n"						\

Well I can fix occasional problems but this is a bitt too much.
I would prefer more careful formatting, like

	USAGE_SELINUX( \
       "	-Z	prints only the security context\n" \
	) \
       "	-g	Prints only the group ID\n" \

This helps to avoid misformatting in help texts.

The rest of this patch needs similar reformatting.
--
vda



More information about the busybox mailing list