svn commit: trunk/busybox: include libbb networking sysklogd

Denis Vlasenko vda.linux at googlemail.com
Sun Feb 4 10:50:51 UTC 2007


On Sunday 04 February 2007 11:32, Bernhard Fischer wrote:
> On Sat, Feb 03, 2007 at 06:39:08PM -0800, vda at busybox.net wrote:
> >Author: vda
> >Date: 2007-02-03 18:39:08 -0800 (Sat, 03 Feb 2007)
> >New Revision: 17749
> 
> >Modified: trunk/busybox/include/libbb.h
> >===================================================================
> >--- trunk/busybox/include/libbb.h	2007-02-04 02:38:21 UTC (rev 17748)
> >+++ trunk/busybox/include/libbb.h	2007-02-04 02:39:08 UTC (rev 17749)
> >@@ -317,13 +317,13 @@
> >  * Currently will return IPv4 or IPv6 sockaddrs only
> >  * (depending on host), but in theory nothing prevents e.g.
> >  * UNIX socket address being returned, IPX sockaddr etc... */
> >-len_and_sockaddr* host2sockaddr(const char *host, int port);
> >+len_and_sockaddr* xhost2sockaddr(const char *host, int port);
> > #if ENABLE_FEATURE_IPV6
> > /* Same, useful if you want to force family (e.g. IPv6) */
> >-len_and_sockaddr* host_and_af2sockaddr(const char *host, int port, sa_family_t af);
> >+len_and_sockaddr* xhost_and_af2sockaddr(const char *host, int port, sa_family_t af);
> 
> Why don't you mark those extern, btw?

Function declarations are externs even if you don't put
extern keyword there, I think. extern is a must only for
variable declarations.

If you know a reason why extern should be there, please let me know.
--
vda



More information about the busybox mailing list