[patch] busybox kill strings.h include

Denys Vlasenko vda.linux at googlemail.com
Thu Aug 16 11:20:53 UTC 2007


On Wednesday 15 August 2007 17:41, maximilian attems wrote:
> klibc has no strings.h and to quote hpa:
> "Including <strings.h> is a bug in the upstream source;
> <strings.h> has been obsolete since at least 1989"
>
>
> Index: e2fsprogs/old_e2fsprogs/ext2fs/bitops.h
> ===================================================================
> --- e2fsprogs/old_e2fsprogs/ext2fs/bitops.h	(revision 19515)
> +++ e2fsprogs/old_e2fsprogs/ext2fs/bitops.h	(working copy)
> @@ -15,7 +15,6 @@
>   */
>
>  #include <string.h>
> -#include <strings.h>
>
>  extern int ext2fs_set_bit(unsigned int nr,void * addr);
>  extern int ext2fs_clear_bit(unsigned int nr, void * addr);
> Index: include/libbb.h
> ===================================================================
> --- include/libbb.h	(revision 19515)
> +++ include/libbb.h	(working copy)
> @@ -26,7 +26,6 @@
>  #include <stdarg.h>
>  #include <stddef.h>
>  #include <string.h>
> -#include <strings.h>
>  #include <sys/ioctl.h>
>  #include <sys/mman.h>
>  #include <sys/socket.h>

Done, thanks.
--
vda



More information about the busybox mailing list