[PATCH] ash.c: repairing kill for susv3

Denis Vlasenko vda.linux at googlemail.com
Sat Apr 21 19:48:00 UTC 2007


On Saturday 21 April 2007 13:24, Mats Erik Andersson wrote:
> tor 2007-04-19 klockan 23:42 +0200 skrev Denis Vlasenko:
> > I propose (a) nuking builtin kill from ALL shells we have.
> > (b) make them call kill applet (grep for 'bb_cat' for an example
> > how to reuse one applet's internals from other applets),
> > and (c) fix any SuSv3 incompatibilities in kill applet.
> > 
> > This way we won't be forced to fix kill five times.
> > 
> > kill from coreutils-6.8 is probably SuSv3 compliant or very
> > close to it. On my system it gives:
> 
> Well, a quick case of code hunting tells me that, of all
> shells presently in Busybox, it is only ash that ships
> with a builtin 'kill' command, whence a correction is a
> one time effort, not a five times repetition. Lest I misunderstood
> that remark about the fiver.

I didn't know how many of our shell had builtin kill, I guessed
maybe all?

If only ash has it, it means unifying it with kill applet will
save "only" one instance of code duplication, not four.
Which is still good.
--
vda



More information about the busybox mailing list