[PATCH - RESEND] addgroup code cleanup, size reduction and feature enhancement

Aurelien Jacobs aurel at gnuage.org
Thu Apr 5 10:42:56 UTC 2007


On Thu, 05 Apr 2007 10:43:10 +0200
Natanael Copa <natanael.copa at gmail.com> wrote:

> On Thu, 2007-04-05 at 08:33 +0200, Tito wrote:
> 
> > 2) crippled function removal:
> > the current addgroup applet when called with 2 arguments
> > permits only to add an existing user to an still to be created group.
> > This seems to me a crippled behavior as it could be used just one time
> > at group creation time: 
> > 
> > root at localhost:~/Desktop/busybox.new# ./busybox_old addgroup prova tito
> > root at localhost:~/Desktop/busybox.new# ./busybox_old addgroup prova dina
> > addgroup: prova: group already in use
> > 
> > 3) the above mentioned feature was re-added as optional
> >     function enabled by ENABLE_FEATURE_ADDUSER_TO_GROUP.
> >     Now    if  called  with two non-option arguments, addgroup will add an existing
> >     user to an existing group like the full blown addgroup does (at least on my system).
> 
> What system do you use? None of mine systems (Gentoo, Ubuntu, Debian,
> FreeBSD, OpenBSD) have an addgroup (or groupadd) that allows me to add a
> user to an existing group.

I've already used this feature at least on Debian and Ubuntu:
  addgroup username groupname
which adds username into the existing groupname.

Aurel



More information about the busybox mailing list