[RFC, PATCH] new applet resize #2
Bernhard Fischer
rep.nop at aon.at
Sun Sep 24 09:18:20 UTC 2006
On Fri, Sep 22, 2006 at 02:33:39PM -0400, Rob Landley wrote:
>On Friday 22 September 2006 3:50 am, Bernhard Fischer wrote:
>> On Thu, Sep 21, 2006 at 11:35:42PM -0400, Rob Landley wrote:
>> >Ok, having caught up on the rest of the thread (being copied on just _some_
>> >messages of a thread is outright weird), lemme elaborate on one part:
>> >
>> >On Thursday 21 September 2006 5:45 pm, Bernhard Fischer wrote:
>> >> It provides for easily setting the TIOS timeout in the NITPICK sectio of
>> >> libbb library tuning, i guess.
>> >
>> >CONFIG_NITPICK is for minor size optimizations. It's not for weird
>tuneables
>>
>> It can depend on CONFIG_NITPICK to eventually show a
>> CONFIG_RESIZE_TERMIOS_TIMEOUT config entry. But it's so trivial to
>> change in the source, than i'm fond of talking about it.
>> I thought that you and rpjday wanted to empower users to toggle stuff
>> with the configury so they do not have to edit the source.
>
>I think that having a CONFIG option is superior to having a comment in the
>source that says "these three lines can be chopped out and replaced with a
>hardwired constant if you're really low on space".
>
>However, if somebody doesn't like the timeout and is motivated to track it
>down, it shouldn't take them too long to find it. (It won't occur to them
>that they _can't_ change the timeout, if they decide they need to.)
fair enough.
>> >In this case, there's no reason for that to _be_ a tuneable. Either it
>works
>> >or it doesn't work, and if it's broken we should fix it. (You don't put in
>a
>> >tuneable for a potential _bug_.)
>>
>> What the are you talking about? If a terminal doesn't respond for
>> whatever reason, why is that a bug?
>
>If we're not waiting long enough to reliably receive the response in an applet
>that has no purpose other than to query for this information, that is a bug.
Yes, i see what you mean. The big, "established" application does set
it's timeout to 10 seconds according to pgf, so the implementation i
suggested just kept that 10 seconds timeout as a way to specify least
deviation from the expected behaviour.
More information about the busybox
mailing list