svn 16201 - 16197

Denis Vlasenko vda.linux at googlemail.com
Sun Sep 24 02:11:36 UTC 2006


On Saturday 23 September 2006 21:45, Tito wrote:
> Hi Denis,
> svn 16201:
> vlock:
> 
> -                printf("Virtual Console%s locked.\n%s's ", (o_lock_all) ? "s" : "", pw->pw_name);
> +                printf("Virtual Console%s locked. Enter %s's password to unlock\n", (o_lock_all) ? "s" : "", pw->pw_name);
> 
> correct_password:
> 
> unencrypted = bb_askpass ( 0, "Password: " );  
> 
> This is bloat and you get a double password prompt, please revert.
> 
> Virtual Console locked. Enter root's password to unlock
> Password:
> 
> This looks uglier than before.....

Before it was as follows:

Virtual Console locked.
root's Password:

ain't it Look wrong? 

The root of it is that correct_password() always uses "Password:"
as a prompt and it also used to do
bb_error_msg_and_die("\nno valid shadow password");
on error, and output on error path looked like this:

Virtual Console locked.
root's vlock:
no valid shadow password

This isn't acceptable, I think.

But you right about bloat. What about this?

Virtual Console locked by root.
Password: _

On error:

Virtual Console locked by root.
vlock: no valid shadow password

> svn 16197:
> passwd:
> why not logmode = LOGMODE_BOTH? and unified error messages?
> 	
>  		syslog(LOG_WARNING, "can't change pwd for '%s'", name);
>   		bb_error_msg_and_die("permission denied");
> 
>               syslog(LOG_WARNING, "password locked for '%s'", np);
>      	        bb_error_msg_and_die("the password for %s cannot be changed", np);
> 
>               syslog(LOG_WARNING, "cannot update password file");
>               bb_error_msg_and_die("cannot update password file");

Yes, good idea...
--
vda



More information about the busybox mailing list