[RFC, PATCH] new applet resize #2
Rob Landley
rob at landley.net
Fri Sep 22 03:35:42 UTC 2006
Ok, having caught up on the rest of the thread (being copied on just _some_
messages of a thread is outright weird), lemme elaborate on one part:
On Thursday 21 September 2006 5:45 pm, Bernhard Fischer wrote:
> It provides for easily setting the TIOS timeout in the NITPICK sectio of
> libbb library tuning, i guess.
CONFIG_NITPICK is for minor size optimizations. It's not for weird tuneables
that don't save size. It's not for adding extra warnings, either. And
currently, it doesn't work properly and won't until I fix some stuff in
menuconfig, which is blocked until we upgrade to the new version from current
kernels, which Denis was working on last I heard.
In this case, there's no reason for that to _be_ a tuneable. Either it works
or it doesn't work, and if it's broken we should fix it. (You don't put in a
tuneable for a potential _bug_.)
A standalone resize applet can have a full second's delay, or even two; if
you're going to call the sucker then you can expect it to wait until it gets
an answer. It's something like an automatic call in bbsh (a heuristic that
can fail) that needs a short (preferably imperceptible) timeout.
Rob
--
Never bet against the cheap plastic solution.
More information about the busybox
mailing list