[RFC, PATCH] new applet resize #2

[Tito]

On Thursday 21 September 2006 23:04, Bernhard Fischer wrote:

snip

> 
> And without being actively stoopid:
>    text    data     bss     dec     hex filename
>     223       0       0     223      df console-tools/resize.o
> 
> 
Hi,

+#if defined(RESIZE_TIOS_TIMEOUT) && (RESIZE_TIOS_TIMEOUT > 0)
+       new.c_cc[VMIN] = 0;
+       new.c_cc[VTIME] = RESIZE_TIOS_TIMEOUT;
+#endif

Just out of curiosity, why do you use all this defines if 

#define RESIZE_TIOS_TIMEOUT 100 /* in deciseconds */

is always defined, wouldn't it be cleaner:

   new.c_cc[VMIN] = 0;
   new.c_cc[VTIME] = 100; /* Timeout in deciseconds */


And, what is this for?

       if (00 && argc > 1)
               printf("COLUMNS=%d;LINES=%d;export COLUMNS LINES;",
                       w.ws_col, w.ws_row);

What is 00?
Why you are testing for argc > 1 when you previously declared:

int resize_main(int ATTRIBUTE_UNUSED argc, char ATTRIBUTE_UNUSED **argv)

Maybe I'm not smart enough to understand this magics.....

Ciao,
Tito