svn 16130
Rich Felker
dalias at aerifal.cx
Mon Sep 18 15:45:02 UTC 2006
On Mon, Sep 18, 2006 at 09:24:48AM -0400, Rob Landley wrote:
> Why this bit?
>
> if (opt_host) {
> - if (ENABLE_FEATURE_UTMP)
> + USE_FEATURE_UTMP(
> safe_strncpy(utent.ut_host, opt_host,
> sizeof(utent.ut_host));
> + )
>
> The if(ENABLE) clause should never cause a config-dependent build break. The
> USE() clause can. It doesn't seem like it will in this instance, but in
> general it's good to use ENABLE where possible, instead of USE(). Why the
> switch from one to the other here?
Probably without ENABLE_FEATURE_UTMP it's allowed for the utmp headers
not to exist..? Should that maybe he hidden in platform.h with dummy
utmp struct and prototypes/macros?
Rich
More information about the busybox
mailing list