Unbreaking allbareconfig (svn 16125).

Bernhard Fischer rep.nop at aon.at
Sun Sep 17 20:50:40 UTC 2006


On Sun, Sep 17, 2006 at 03:42:27PM -0500, Jason Schoon wrote:
>On 9/17/06, Bernhard Fischer <rep.nop at aon.at> wrote:
>>
>>On Sun, Sep 17, 2006 at 02:05:03PM -0400, Rich Felker wrote:
>>>On Sun, Sep 17, 2006 at 05:16:21PM +0200, walter harms wrote:
>>>> hi,
>>>> just a reminder that paths.h contains:
>>>>  _PATH_TTY       "/dev/tty"
>>>>  _PATH_CONSOLE   "/dev/console"
>>>>
>>>> i am just intending to prevent to invent that wheel again.
>>>
>>>Using #defines for these is even more nonsensical than using external
>>>string vars. At least the extern vars save a few bytes. The defines
>>>just attempt to abstract something that WILL NEVER CHANGE. Not to
>>
>>
>>>mention these are glibc-specific (all of paths.h is).
>>yes.
>>There is no reliant content of paths.h at all. We absolutely have to
>>provide these as we use them.
>
>
>If we are going to provide them, it would be ideal if we could stick them in
>some kind of defined array, or at least provide them as extern const char*.
>As noted earlier, just doing the defines does provide simpler changing of
>code in one spot, but no space savings.

Most of them should already be extern const char * const
See include/libbb.h

I take it that several applets are doing these on their own. These
applets want a cleanup to use the libbb provided symbols.



More information about the busybox mailing list