[PATCH] one more fix for make defconfig in syslogd

[Tito]

On Monday 11 September 2006 09:28, you wrote:
> On Sun, Sep 10, 2006 at 11:12:35PM +0200, Tito wrote:
> >Hi,
> >a new error popped for make defconfig; make with gcc 4.0
> >
> >make
> >  CC sysklogd/syslogd.o
> >cc1: warnings being treated as errors
> >/root/Desktop/busybox.test/sysklogd/syslogd.c: In function ???message???:
> >/root/Desktop/busybox.test/sysklogd/syslogd.c:261: warning: ???fd??? may be used uninitialized in this function
> >make[1]: *** [/root/Desktop/busybox.test/sysklogd/syslogd.o] Error 1
> >make: *** [_all] Error 2
> >
> >This patch should fix it.
> >The patch is only compile tested.
> 
> I strongly dislike these so called fixes. If we *know* that it is
> impossible to hit a use when a variable is _not_ initialized, then
> initializing that variable is nonsense (as is -Werror in this case).
> It justs adds to the size for absolutely no benefit.
> 
Yes, i agree with you, but on the other side 
we cannot ship a broken build system,
so or we fix or remove make defconfig
or at least -Werror
or we fix the code.
I personally will not touch the makefiles
magics............

Ciao,
Tito