svn commit: trunk/busybox: archival libbb

Rob Landley rob at landley.net
Sun Sep 10 17:39:45 UTC 2006


On Sunday 10 September 2006 8:02 am, Tito wrote:
> "bb_[p]error prints "<appletname>: <message>\n". Starting <message>
> with capital letter is not correct wrt English language.
> I am nitpicking here..."
>
>  bb_info_msg("Something");

You are aware that several of our error messages are "ioctl" or similar?  
Because this error message is very small?

You are also aware that these are english strings hardwired into the code, not 
internationalized?

Personally, I prefer the capitalized versions.  I also think this is an 
example of pointless churn that accomplishes nothing and I politely ask that 
it please stop.  If you're making the error message clearer, or smaller, 
fine.  Quit fiddling with the capitalization.

> This sure is correct, but in my opinion is not worth the effort...
> and to be the biggest of "nitpickers" i would suggest to add a dot "."
> at the end of every sentence increasing the size of bb a few  Kb.

No.

> BTW.: I remember in some places we have made such errors
>         deliberately to make 2 or more text strings be the same
>         and reduce size. Maybe after doing this corrections a
>         check for size increase could be useful.

Running bloatcheck before a checkin is generally useful.  I added an rodata 
section comparison to that for a reason. :)

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list