Problems at shutdown
Andy Green
andy at warmcat.com
Wed Nov 29 14:51:24 UTC 2006
Bernhard Fischer wrote:
Hi Bernhard -
> Understood. We have USE_foobar nowadays, all USAGE_barbaz in usage.h
> have to be removed piece by piece.
Alright now I am with you.
>>> Please resend (would be awesome if you could cleanup the other uses of
>>> USAGE_MTAB while you're at it), thanks
I decided to clean up the whole usage.h for this issue since I think I
understood the situation well enough to try it. The original two
changes are in this diff too using the USE_ system now.
Two bugs came out of it
- CONFIG_FEATURE_MOUNT_FORCE never exists
It is for umount, not mount despite the name. In the code for umount,
it seems to be enabled always. So I changed usage.h to reflect that.
- CONFIG_FEATURE_TAR_EXCLUDE never exists
The -X switch is therefore never shown in the --help for tar up until
now. But it seems the feature is supported in the code for tar
depending on CONFIG_FEATURE_TAR_FROM. So I changed this in usage.h too
to depend on the same CONFIG_.
There are two instances remaining of USAGE_ where there is some logic
done to work out what to allow and it doesn't fit in the USE_SKIP way,
so I leave those.
-Andy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-1.2.2.1-cleaned-usage.h
Type: text/x-chdr
Size: 27527 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20061129/a9f45a54/attachment-0002.h
More information about the busybox
mailing list