[PATCH] deluser size reduction

Tito farmatito at tiscali.it
Sun Nov 26 17:35:40 UTC 2006


On Sunday 26 November 2006 18:18, Denis Vlasenko wrote:
> On Sunday 26 November 2006 18:06, Tito wrote:
> > Hi,
> > this patch reduces the size of deluser/delgroup.
> > Bloatcheck is:
> > 
> > function                                             old     new   delta
> > del_line_matching                                    265     219     -46
> > ------------------------------------------------------------------------------
> > (add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-46)             Total: -46 bytes
> > 
> > The patch is tested and seems to work fine at least for me.
> > Please apply if you like it.
> 
> Will take a look later today, ok?

Fine.

> 
> > BTW, in current svn make defconfig;make is broken:
> > make
> >   SPLIT   include/autoconf.h -> include/config/*
> >   GEN     include/bbconfigopts.h
> >   HOSTCC  applets/usage
> >   GEN     include/usage_compressed.h
> >   CC      applets/applets.o
> > In file included from include/libbb.h:318,
> >                  from include/busybox.h:10,
> >                  from applets/applets.c:15:
> > include/xatonum.h:80:18: error: "ULLONG_MAX" is not defined
> > include/xatonum.h:88:17: error: "ULLONG_MAX" is not defined
> > make[1]: *** [applets/applets.o] Error 1
> > make: *** [applets] Error 2
> 
> uclibc?

No, gnu libc 2.3.6 on ubuntu 6.06.1.
> 
> Can you check whether adding "gcc -std=c99" or "gcc -std=gnu99"
> fixes this?

Adding where?
I've tried make -std=c99, but this doesn't work.
My makfile-fu is very limited  ;(

Ciao,
Tito
> vda
> 



More information about the busybox mailing list