[PATCH] dhcprelay

Bernhard Fischer rep.nop at aon.at
Tue Nov 21 11:35:19 UTC 2006


On Mon, Nov 20, 2006 at 08:44:27PM +0100, Denis Vlasenko wrote:
>On Monday 20 November 2006 13:23, Bernhard Fischer wrote:
>> On Fri, Nov 03, 2006 at 12:13:52AM +0100, Denis Vlasenko wrote:
>> >On Thursday 02 November 2006 12:29, Bernhard Fischer wrote:

>> >> Didn't look at the code, but it sounds useful.
>> >> vda, care to apply this?
>> >Sure. Where's the patch?
>> It was posted earlier in this thread.
>Applied with some amount of manual fixing. :(
>Please test current svn...
>
>
>If sendto will for some unfathomable reason return
>positive res here:
>
>        res = sendto(fds[0], p, packet_len, 0, (struct sockaddr*)server_addr,
>                        sizeof(struct sockaddr_in));
>        if (res != packet_len) {
>                bb_perror_msg("pass_on");
>                return;
>        }
>
>We will get dreaded "Success" error message:
>
>dhcpreplay: pass_on: Success
>
>Utterly confusing.
>
>Maybe check for < 0 return value?

Also:
listen_socket:
	- we have these twice. Once static in dnsd.c and the ones in
	  uchdp/; The latter does always die in it's callers but doesn't
	  use xsocket..

networking/udhcp/common.h:
	These silly #defines should IMHO go away.




More information about the busybox mailing list