[PATCH] dhcprelay

[Denis Vlasenko]

On Monday 20 November 2006 13:23, Bernhard Fischer wrote:
> On Fri, Nov 03, 2006 at 12:13:52AM +0100, Denis Vlasenko wrote:
> >On Thursday 02 November 2006 12:29, Bernhard Fischer wrote:
> >> On Sat, Sep 23, 2006 at 08:31:39AM +0200, Thomas Lundquist wrote:
> >> >On Fri, Sep 22, 2006 at 12:48:17PM -0700, Jesse Dutton wrote:
> >> >
> >> >>  In essence, it routes dhcp.
> >> >
> >> >and yes, it is useful.
> >> 
> >> Didn't look at the code, but it sounds useful.
> >> 
> >> vda, care to apply this?
> >
> >Sure. Where's the patch?
> 
> It was posted earlier in this thread.
> For your convenience, here is the second incarnation of the Jesse's
> patch:
> http://busybox.net/lists/busybox/2006-September/024659.html

Applied with some amount of manual fixing. :(
Please test current svn...


If sendto will for some unfathomable reason return
positive res here:

        res = sendto(fds[0], p, packet_len, 0, (struct sockaddr*)server_addr,
                        sizeof(struct sockaddr_in));
        if (res != packet_len) {
                bb_perror_msg("pass_on");
                return;
        }

We will get dreaded "Success" error message:

dhcpreplay: pass_on: Success

Utterly confusing.

Maybe check for < 0 return value?
--
vda