[PATCH] CFLAGS_EXTRA and quotes
Rob Landley
rob at landley.net
Wed May 31 22:16:52 UTC 2006
On Saturday 27 May 2006 1:56 pm, Lucas C. Villa Real wrote:
> On 5/25/06, Mike Frysinger <vapier at gentoo.org> wrote:
> > On Wednesday 17 May 2006 15:01, Lucas C. Villa Real wrote:
> > > Is there a reason to remove double quotes (") from CFLAGS_EXTRA? That
> > > breaks the usage of flags such as "-DFOODIR=\"/path/to/foo\"".
> > >
> > > I'm asking that because of a patch I'm going to submit to make
> > > "/lib/modules" configurable at modprobe.c, given that one can already
> > > specify a different MODDIR at the kernel's Makefile.
> >
> > imo you should be passing defines via the menuconfig system and thus
> > generated header files, not via CFLAG hax
>
> Something like the attached patch? (against 1.1.3, still needs to be
> rediffed against svn)
1) The USING_ALTERNATE_MODDIR serves no purpose. If you're going to make it
configurable at all, just have a sane default for the CONFIG entry.
2) Why is /lib/modules not the directory this goes in? Why does everybody
want to change every possible directory all of the sudden? This can't be
because Dec Ultrix had a different path for this because insmod deals with
linux kernel modules. Specifically linux.
What's the motivation for this? Has anybody ever specified a different
MODDIR?
Rob
--
Never bet against the cheap plastic solution.
More information about the busybox
mailing list