patch: init's halt message

Bernhard Fischer rep.nop at aon.at
Tue May 30 17:13:58 UTC 2006


On Tue, May 30, 2006 at 12:37:04PM -0400, Paul Fox wrote:
>anyone object to changing init's final message?  the current
>message says "The system is halted" when that is not actually
>the case.  when the kernel actually does halt, or powerdown, it
>will print its own message.  seems better if init only announces
>what it's trying to do, rather than claiming to have done it.

I don't really care myself, but your change looks like it would add to
the size a bit, yes? I think that the big init does print about the same
message, so i wouldn't care too much if it adds size, FWIW

Perhaps shrink init elsewhere to accommodate the UI improvement? :)
>
>paul
>
>Index: init/init.c
>===================================================================
>diff -u -r1.1.1.1 init.c
>--- init/init.c	30 May 2006 15:18:09 -0000	1.1.1.1
>+++ init/init.c	30 May 2006 16:35:07 -0000
>@@ -757,7 +757,8 @@
> static void halt_signal(int sig ATTRIBUTE_UNUSED)
> {
> 	shutdown_system();
>-	message(CONSOLE | LOG, "The system is halted.");
>+	message(CONSOLE | LOG, "Requesting system %s.",
>+		sig == SIGUSR2 ? "poweroff." : "halt.");
> 	sync();
> 
> 	/* allow time for last message to reach serial console */
>
>=---------------------
> paul fox, pgf at brightstareng.com
>_______________________________________________
>busybox mailing list
>busybox at busybox.net
>http://busybox.net/cgi-bin/mailman/listinfo/busybox
>



More information about the busybox mailing list