svn commit: trunk/busybox: archival/libunarchive include libbb miscetc...

Tue May 30 06:28:40 UTC 2006

On Monday 29 May 2006 4:14 am, Peter Kjellerstedt wrote:
> > +#if BB_BIG_ENDIAN
> > +#define SWAP_BE16(x) x
> > +#define SWAP_BE32(x) x
> > +#define SWAP_BE64(x) x
>
> Please correct the three defines above to be defined to (x) rather
> than just x. Otherwise a construct like SWAP_BE16(VALUE1 | VALUE2) &
> MASK
> will be evaluated as VALUE1 | (VALUE2 & MASK) on a BE machine...

Done.

Rob
-- 
Never bet against the cheap plastic solution.