[PATCH] remove shm* from hdparm

Tito farmatito at tiscali.it
Wed May 24 19:03:02 UTC 2006


On Wednesday 24 May 2006 19:14, Bernhard Fischer wrote:
> Hi Tito,
> 
> First, i did
> -#include <endian.h>
> since we include that from platform.h
> Second, i'm wondering what the __USE_XOPEN does there? Looks odd to me,
> given that no single file is included afterwards. Ok to remove or should
> it be moved before an include to have an effect?
> 
Hi,
The original in hdparm-6.6+/identify.c
is before <unistd.h> and  <linux/types.h>	/* for __u16 */
(via "hdparm.h")

#include <endian.h>

#if __BYTE_ORDER == __BIG_ENDIAN
#define __USE_XOPEN
#endif

#include <unistd.h>
#include "hdparm.h"

So we should move it to the top, i think.
BTW, we should remove also #include <sys/shm.h>
a leftover of the shm* stuff.

I will add this to my next size reduction patch, that so far does:

Remove -v verbose -V version -q quiet flags
Remove parse_opt_v2()
Rename parse_opt_v3() to parse_xfermode()
Remove if_strcat()
Rearrange code in  dump_identity() to reduce size
Modify some strings so that they could be optimized by the compiler
Minor code clean up.


Ciao,
Tito




More information about the busybox mailing list