svn commit: trunk/busybox

Rob Landley rob at landley.net
Wed May 24 17:52:14 UTC 2006


On Wednesday 24 May 2006 5:59 am, Bernhard Fischer wrote:
> FYI,

I presume that when I read through my busybox list backlog this weekend I'll 
find out who this message was from.  >&2 replaces the "must have 
a /dev/stderr" dependency with a "must be running bash" dependency, but I 
suppose we already have that...

Rob

> On Wed, Apr 19, 2006 at 01:32:31PM -0700, landley at busybox.net wrote:
> >Author: landley
> >Date: 2006-04-19 13:32:27 -0700 (Wed, 19 Apr 2006)
> >New Revision: 14923
> >
> >Log:
> >svn 14824 broke -funsigned-char and possibly building out of tree, because
> >$(srcdir) can't bind early since it's set to a different value in each
> > subdir. If it binds early, it's blank, hence an empty -I which eats the
> > next option as a directory to look for #include files in.
> >
> >So CFLAGS has to bind late, but the check_gcc stuff should only get run
> > once. I added a "make V=2" mode to show when check_gcc gets run, and
> > turned WARNINGS into a CFLAGS line since it was always getting added
> > anyway.
> >
> >
> >Modified:
> >   trunk/busybox/Rules.mak
> >
> >Modified: trunk/busybox/Rules.mak
> >===================================================================
> >--- trunk/busybox/Rules.mak	2006-04-19 20:24:12 UTC (rev 14922)
> >+++ trunk/busybox/Rules.mak	2006-04-19 20:32:27 UTC (rev 14923)
> >@@ -100,8 +103,13 @@
> > 		)
> > endif
> >
> >-# A nifty macro to make testing gcc features easier
> >+# A nifty macro to make testing gcc features easier, but note that
> > everything +# that uses this _must_ use := or it will be re-evaluated for
> > every file. +ifeq ($(strip $(V)),2)
> >+VERBOSE_CHECK_GCC=echo check_gcc $(1) >> /dev/stderr;
> >+endif
> > check_gcc=$(shell \
> >+	$(VERBOSE_CHECK_GCC)\
> > 	if [ "$(1)" != "" ]; then \
> > 		if $(CC) $(1) -S -o /dev/null -xc /dev/null > /dev/null 2>&1; \
> > 		then echo "$(1)"; else echo "$(2)"; fi \
>
> You're now filling my  mount | grep /\
> root_domain#root on / type advfs (rw)
> with superfluous stuff..
> Most likely you ment
> s/\/dev\/stderr/>&2/
>
> I'll correct this soonish.

-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list