What about breaking trunk? [was: Re: Review of the last few applied patches...]

[Rob Landley]

On Friday 19 May 2006 2:52 pm, Bernhard Fischer wrote:
> This is disgusting.
>
> I'm tempted to add a CONFIG_DEBUG_KEEP_NLS_CRAP which undefines _ (see
> platform.h, NLS cruft)
> and force anyone into a quick but stringently needed cleanup of this
> mess before we freeze for 1.2.
>
>
> Index: include/platform.h
> ===================================================================
> --- include/platform.h	(revision 15140)
> +++ include/platform.h	(working copy)
> @@ -99,9 +99,11 @@
>  #endif
>
>  /* ---- miscellaneous --------------------------------------- */
> +#if ENABLE_DEBUG_KEEP_NLS_CRAP
>  /* NLS stuff */
>  /* THIS SHOULD BE CLEANED OUT OF THE TREE ENTIRELY */
>  #define _(Text) Text
>  #define N_(Text) (Text)
> +#endif
>

Yeah, I noticed that earlier. :)

Breaking the tree doesn't actually force people to do work, but then this is 
simple enough for _me_ to do if necessary (it's a todo item of mine already) 
that I don't have an objection.  But don't #ifdef it out, just _yank_ the 
sucker and let's get this cleaned up.

Breaking the tree in a good cause is what the -devel branch is for, and we 
ain't frozen yet. :)

Rob
-- 
Never bet against the cheap plastic solution.