should SLIP support be removed?

Robert P. J. Day rpjday at mindspring.com
Thu May 18 19:51:31 UTC 2006


On Thu, 18 May 2006, Andy Green wrote:

> Robert P. J. Day wrote:
>
> > well, since you claim that SLIP works for you, why don't you
> > remove that undef and see what happens after that?  without
> > looking too closely at the code, maybe it will fix some of those
> > aesthetic issues for you.  one can always dream.
>
> busybox-1.1.2/networking/interface.c:1516: error: 'slip_hwtype' undeclared
> here (not in a function)
> busybox-1.1.2/networking/interface.c:1517: error: 'cslip_hwtype' undeclared
> here (not in a function)
> busybox-1.1.2/networking/interface.c:1518: error: 'slip6_hwtype' undeclared
> here (not in a function)
> busybox-1.1.2/networking/interface.c:1519: error: 'cslip6_hwtype' undeclared
> here (not in a function)
> busybox-1.1.2/networking/interface.c:1520: error: 'adaptive_hwtype' undeclared
> here (not in a function)
>
> $ grep slip_hwtype * -R
> networking/interface.c: &slip_hwtype,
> networking/interface.c: &cslip_hwtype,
> networking/interface.c: slip_hwtype.title = _("Serial Line IP");
> networking/interface.c: cslip_hwtype.title = _("VJ Serial Line IP");
>
> Looks like you might as well optimize HWSLIP stuff out.
>
> SLIP works fine without it with net-tools slattach and busybox
> ifconfig.

does anyone else have any opinions on whether the HWSLIP stuff in
networking/interface.c has any value?  or can it be trashed?

rday



More information about the busybox mailing list