[PATCH, revised] kernel versioning stuff
Robert P. J. Day
rpjday at mindspring.com
Thu May 18 17:02:45 UTC 2006
On Thu, 18 May 2006, Yann E. MORIN wrote:
> Hello all!
>
> On Thursday 18 May 2006 183, Robert P. J. Day wrote:
> > thoughts?
>
> In modprobe, we also need to know wether running under 2.6 or 2.4,
> and I think we could/should use your new functions to check for
> that.
>
> Let me patch it here, and I'll send a patch later tonight (dinner's
> on the fire atm).
ok. you might want to consider that change as a separate patch to be
applied after mine. i use subversion on a couple of my own projects
and i make it a habit of defining each of my commits to represent a
single, well-defined "change".
so *my* patch would represent simply taking what's there and making it
consistent. *your* patch is different -- it represents adding actual
new functionality.
at least, that's the way i look at it. how you choose to do it is up
to you but making your submission a separate commit means it can be
backed out separately if something goes wrong without affecting the
rest of it.
rday
More information about the busybox
mailing list